feat(eng-2261): License policy CLI#113
Conversation
|
Looks good at first glance. I think I confused you earlier with the whole license/licence discussion. We should adhere to "International English" in anything user-facing like commands and output. Maybe it would be better to switch back to using "license" everywhere to avoid confusion, and if you have any cases where a variable named "license" shadows the builtin, then you could just append an underscore to the variable name i.e. license_ |
The only place |
chrisimcevoy
left a comment
There was a problem hiding this comment.
Looks great, just a handful of tiny nitpicks. Approved in advance.
|
Code Climate has analyzed commit b315a2a and detected 15 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 96.2% (50% is the threshold). This pull request will bring the total coverage in the repository to 56.9% (1.6% change). View more on Code Climate. |
Adds functionality to manage license policies via CLI